xinrong-databricks commented on a change in pull request #32785:
URL: https://github.com/apache/spark/pull/32785#discussion_r647616907
##########
File path: python/pyspark/pandas/data_type_ops/base.py
##########
@@ -52,33 +52,42 @@
from pyspark.pandas.series import Series # noqa: F401 (SPARK-34943)
-def is_valid_operand_for_numeric_arithmetic(operand: Any, *, allow_bool: bool
= True) -> bool:
- """Check whether the operand is valid for arithmetic operations against
numerics."""
+def is_valid_operand_for_numeric_arithmetic(
+ operand: Any, *, allow_bool_index_ops: bool = True, allow_bool: bool = True
Review comment:
There is a case `allow_bool_index_ops` is not allowed, thus,
`allow_bool` is allowed alone.
`allow_bool_index_ops` is set `True` for arithmetics operations against
numeric Series and Indexes in order to enable cases as
```py
>>> ps.Series([1, 2, 3]) + ps.Series([True, False, True])
0 2
1 2
2 4
dtype: int64
```
However, the case below is not supported now.
```py
>>> ps.Series([True, False, True]) + ps.Series([True, False, True])
Traceback (most recent call last):
...
TypeError: Addition can not be applied to booleans and the given type.
```
The two cases above both use `is_valid_operand_for_numeric_arithmetic` as an
input validation, so `allow_bool_index_ops` might be needed.
How do you think about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
