cloud-fan commented on a change in pull request #32824:
URL: https://github.com/apache/spark/pull/32824#discussion_r647619407
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -258,19 +258,17 @@ class UserDefinedTypeSuite extends QueryTest with
SharedSparkSession with Parque
test("SPARK-30993: UserDefinedType matched to fixed length SQL type
shouldn't be corrupted") {
def concatFoo(a: FooWithDate, b: FooWithDate): FooWithDate = {
- FooWithDate(b.date, a.s + b.s, a.i)
+ FooWithDate(b.year, a.s + b.s, a.i)
}
- UDTRegistration.register(classOf[LocalDateTime].getName,
classOf[LocalDateTimeUDT].getName)
+ UDTRegistration.register(classOf[Year].getName, classOf[YearUDT].getName)
Review comment:
shall we unregister it after test finishes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
