viirya commented on a change in pull request #32800:
URL: https://github.com/apache/spark/pull/32800#discussion_r647807058
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -298,10 +298,12 @@ private[spark] class BlockManager(
protected def saveToDiskStore(): Unit
- private def saveDeserializedValuesToMemoryStore(inputStream: InputStream):
Boolean = {
+ private def saveDeserializedValuesToMemoryStore(
+ inputStream: InputStream,
+ memoryMode: MemoryMode): Boolean = {
Review comment:
nit: seems no need to pass `memoryMode`, just follow `level.memoryMode`.
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -706,6 +709,7 @@ private class SerializedValuesHolder[T](
classTag: ClassTag[T],
memoryMode: MemoryMode,
serializerManager: SerializerManager) extends ValuesHolder[T] {
+
Review comment:
nit: unnecessary blank?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
