srowen commented on pull request #32813: URL: https://github.com/apache/spark/pull/32813#issuecomment-857201726
To recap what I think we can do here is: - (If you would revert the formatting changes) - If it's not too hard, put in this unit test. That's very valuable - Make the option _configurable_ rather than default to false as an interim step - Certainly note this in docs that it's not recommended to set to 'true' A followup, which maybe I can look into then, is: - Can this be 'fixed' with a change to the merge condition? that'd be ideal, unless it just makes it pointless on normalish data sets - If not, then I make it default to false - And update the migration guide with the behavior change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
