Victsm commented on a change in pull request #30691:
URL: https://github.com/apache/spark/pull/30691#discussion_r647877273



##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1982,6 +1978,8 @@ private[spark] class DAGScheduler(
               case failedMapStage: ShuffleMapStage =>
                 // Mark all the map as broken in the map stage, to ensure 
retry all the tasks on
                 // resubmitted stage attempt.
+                // TODO: SPARK-32923: Clean all push-based shuffle metadata 
like merge enabled and
+                // TODO: finalized as we are clearing all the merge results.

Review comment:
       Nit: this TODO should be moved to inside `submitMissingTasks` (line 
1326) where it's handling indeterminate stage.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to