dongjoon-hyun commented on a change in pull request #32610:
URL: https://github.com/apache/spark/pull/32610#discussion_r648007320
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -250,11 +250,32 @@ private[spark] object Config extends Logging {
.stringConf
.createOptional
+ // the definition of a label in DNS (RFC 1123).
+ private val dns1123LabelFmt = "[a-z0-9]([-a-z0-9]*[a-z0-9])?"
+
+ private val podConfValidator =
(s"^$dns1123LabelFmt(\\.$dns1123LabelFmt)*$$").r.pattern
+
+ // The possible longest executor name would be
"$prefix-exec-${Long.MaxValue}"
Review comment:
It looks worth to have a separate PR, @yaooqinn . Could you make a new
PR for `AtomicLong(0L)` change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
