viirya commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r648022478
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
Review comment:
Only exceptional one might be, if a v2 implementation can only handle
quoted "dots", but not other quoted chars, right? I think it should be rare
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
