sarutak edited a comment on pull request #32786: URL: https://github.com/apache/spark/pull/32786#issuecomment-857479722
I considered the following comments from @cloud-fan and @hvanhovell . https://github.com/apache/spark/pull/32786#discussion_r647073606 https://github.com/apache/spark/pull/32786#discussion_r647338534 Then, I add `MetricsAggregatingAccumulator`, a sub class of `AggregatingAccumulator`, for the requirement that executors performs `merge` for `CollectMetricsExec` rather than modifying or overloading `withSQL` in `AggregatingAccumulator` because the requirement is specific only for `CollectMetricsExec`. `setState` is restored and `addState` is removed to response to the [comment](https://github.com/apache/spark/pull/32786#discussion_r647338534). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
