cloud-fan commented on a change in pull request #32401:
URL: https://github.com/apache/spark/pull/32401#discussion_r648092216
##########
File path:
core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java
##########
@@ -164,6 +180,13 @@ public void write(Iterator<Product2<K, V>> records) throws
IOException {
}
partitionLengths = writePartitionedData(mapOutputWriter);
+ if (checksumEnabled) {
+ long[] checksums = new long[numPartitions];
+ for (int i = 0; i < numPartitions; i ++) {
+ checksums[i] = partitionChecksums[i].getValue();
+ }
+ IndexShuffleBlockResolver.get().writeChecksumFile(shuffleId, mapId,
checksums);
Review comment:
Oh actually we did, but it's done by
`ShuffleMapOutputWriter.commitAllPartitions`. Does this checksum file work with
custom shuffle extensions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
