cloud-fan commented on a change in pull request #32839:
URL: https://github.com/apache/spark/pull/32839#discussion_r648460381
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -385,9 +385,16 @@ object DateTimeUtils {
* microseconds where microsecond 0 is 1970-01-01 00:00:00Z.
*/
def instantToMicros(instant: Instant): Long = {
- val us = Math.multiplyExact(instant.getEpochSecond, MICROS_PER_SECOND)
- val result = Math.addExact(us, NANOSECONDS.toMicros(instant.getNano))
- result
+ val secs = instant.getEpochSecond
+ if (secs == Math.floorDiv(Long.MinValue, MICROS_PER_SECOND)) {
+ val us = Math.multiplyExact(secs + 1, MICROS_PER_SECOND)
Review comment:
Yea this should be a constant, but after we enter the if branch and
reach here, it's rare and I'm OK to not have a constant for `val us = ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
