ueshin commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r648666568
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -685,7 +687,7 @@ def __setitem__(self, key, value):
psdf[temp_key_col] = rows_sel
if isinstance(value, Series):
psdf[temp_value_col] = value
- psdf =
psdf.sort_values(temp_natural_order).drop(temp_natural_order)
+ psdf =
psdf.sort_values(temp_natural_order).drop(temp_natural_order) # type: ignore
Review comment:
nit: seems like we don't need `ignore` here.
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1802,7 +1810,7 @@ def __setitem__(self, key, value):
)
super().__setitem__(key, value)
# Update again with resolved_copy to drop extra columns.
- self._psdf._update_internal_frame(
+ self._psdf._update_internal_frame( # type: ignore
Review comment:
nit: seems like we don't need `ignore` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
