viirya commented on a change in pull request #32885:
URL: https://github.com/apache/spark/pull/32885#discussion_r650152680
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -278,11 +278,6 @@ case class AttributeReference(
case _ => false
}
- override def semanticEquals(other: Expression): Boolean = other match {
- case ar: AttributeReference => sameRef(ar)
- case _ => false
- }
-
Review comment:
Don't need `canonicalized`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -127,11 +126,6 @@ case class InSubqueryExec(
override def withNewPlan(plan: BaseSubqueryExec): InSubqueryExec = copy(plan
= plan)
final override def nodePatternsInternal: Seq[TreePattern] =
Seq(IN_SUBQUERY_EXEC)
- override def semanticEquals(other: Expression): Boolean = other match {
- case in: InSubqueryExec => child.semanticEquals(in.child) &&
plan.sameResult(in.plan)
- case _ => false
- }
-
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
