[GitHub] [spark] wangyum commented on a change in pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

Mon, 14 Jun 2021 00:34:48 -0700 


wangyum commented on a change in pull request #32410:
URL: https://github.com/apache/spark/pull/32410#discussion_r650064530



##########
File path: 
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
##########
@@ -141,7 +141,8 @@ public void open(Map<String, String> sessionConfMap) throws 
HiveSQLException {
     sessionState = new SessionState(hiveConf, username);
     sessionState.setUserIpAddress(ipAddress);
     sessionState.setIsHiveServerQuery(true);
-    SessionState.start(sessionState);
+    // Use setCurrentSessionState to avoid creating useless SessionDirs.
+    SessionState.setCurrentSessionState(sessionState);

Review comment:
       It has removed by 
https://github.com/apache/hive/commit/9bebaf6196c1842c285bfbad50765170e064f6e4.
   
   
![image](https://user-images.githubusercontent.com/5399861/121709709-67b62080-cb0b-11eb-9887-ed43258acd1c.png)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to