yikf commented on a change in pull request #32877:
URL: https://github.com/apache/spark/pull/32877#discussion_r649999826
##########
File path: core/src/main/scala/org/apache/spark/ContextCleaner.scala
##########
@@ -188,7 +188,7 @@ private[spark] class ContextCleaner(
private def keepCleaning(): Unit = Utils.tryOrStopSparkContext(sc) {
while (!stopped) {
try {
- val reference =
Option(referenceQueue.remove(ContextCleaner.REF_QUEUE_POLL_TIMEOUT))
+ val reference = Option(referenceQueue.remove())
Review comment:
Hm, This is a issue too, I'm thinking, `while (!stopped)` means `while
(true)` if there is no stop all the time, the will lead to some ineffective
loop, I'm not sure if there are some ineffective effects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
