ekoifman commented on a change in pull request #32872:
URL: https://github.com/apache/spark/pull/32872#discussion_r649665188
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1567,7 +1567,7 @@ class AdaptiveQueryExecSuite
assert(!smj.head.isSkewJoin)
// Both sides are coalesced.
val customReaders = collect(smj.head) {
- case c: CustomShuffleReaderExec if c.hasCoalescedPartition => c
+ case c: CustomShuffleReaderExec => c
Review comment:
yes and no. Sometimes empty partitions get dropped but not always. The
comment in the code just above
https://github.com/apache/spark/pull/32776/files#r648846235 explains this
exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
