cloud-fan commented on a change in pull request #32899:
URL: https://github.com/apache/spark/pull/32899#discussion_r650971071
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1093,21 +1126,9 @@ class Dataset[T] private[sql](
// Otherwise, find the trivially true predicates and automatically
resolves them to both sides.
// By the time we get here, since we have already run analysis, all
attributes should've been
// resolved and become AttributeReference.
- val cond = plan.condition.map { _.transform {
- case catalyst.expressions.EqualTo(a: AttributeReference, b:
AttributeReference)
- if a.sameRef(b) =>
- catalyst.expressions.EqualTo(
- withPlan(plan.left).resolve(a.name),
Review comment:
the existing code uses `resolve` not `resolveQuoted`, shall we keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
