Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5820#discussion_r29539722
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -21,8 +21,6 @@ import java.io.PrintWriter
import scala.reflect.ClassTag
--- End diff --
It's not in this story, but I'm curious why we don't exclude sharedParams
in git, and dynamically call `SharedParamsCodeGen` in build script to ensure
the consistency?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
