Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5853#discussion_r29540337
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala
 ---
    @@ -108,9 +110,13 @@ class WriteAheadLogBackedBlockRDD[T: ClassTag](
               // writing log data. However, the directory is not needed if 
data needs to be read, hence
               // a dummy path is provided to satisfy the method parameter 
requirements.
               // FileBasedWriteAheadLog will not create any file or directory 
at that path.
    -          val dummyDirectory = FileUtils.getTempDirectoryPath()
    +          // FileBasedWriteAheadLog will not create any file or directory 
at that path. Also,
    +          // this dummy directory should not already exist otherwise the 
WAL will try to recover
    +          // past events from the directory and throw errors.
    +          val nonExistentDirectory = new File(
    +            FileUtils.getTempDirectory(), 
UUID.randomUUID().toString).getAbsolutePath
    --- End diff --
    
    I keep trying to get rid of uses of commons-io since it is not actually a 
Spark dependency. This can be `Utils.createTempDir`? The other usage in 
`StreamingContextSuite` can be replaced with Guava. Not exactly the topic of 
this PR but might yet be worth doing if you're potentially removing this usage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to