dongjoon-hyun commented on a change in pull request #32291:
URL: https://github.com/apache/spark/pull/32291#discussion_r654666095
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/SizeInBytesOnlyStatsPlanVisitor.scala
##########
@@ -67,7 +67,7 @@ object SizeInBytesOnlyStatsPlanVisitor extends
LogicalPlanVisitor[Statistics] {
}
}
- override def visitDistinct(p: Distinct): Statistics = default(p)
+ override def visitDistinct(p: Distinct): Statistics = visitUnaryNode(p)
Review comment:
Do we have a test coverage for this change? The newly added test case
seems to pass without this change.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/SizeInBytesOnlyStatsPlanVisitor.scala
##########
@@ -67,7 +67,7 @@ object SizeInBytesOnlyStatsPlanVisitor extends
LogicalPlanVisitor[Statistics] {
}
}
- override def visitDistinct(p: Distinct): Statistics = default(p)
+ override def visitDistinct(p: Distinct): Statistics = visitUnaryNode(p)
Review comment:
Do we have a test coverage for this change? The newly added test case
seems to pass without this change. If this is required, please add a test
coverage for this change.
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala
##########
@@ -235,7 +235,6 @@ class BasicStatsEstimationSuite extends PlanTest with
StatsEstimationTestBase {
test("SPARK-34121: Intersect operator missing rowCount when enable CBO") {
val intersect = Intersect(plan, plan, false)
- val childrenSize = intersect.children.size
Review comment:
super nit. irrelevant change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
