aokolnychyi commented on a change in pull request #32921:
URL: https://github.com/apache/spark/pull/32921#discussion_r654731571
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -96,6 +96,7 @@ case class AdaptiveSparkPlanExec(
@transient private val queryStageOptimizerRules: Seq[Rule[SparkPlan]] = Seq(
PlanAdaptiveDynamicPruningFilters(this),
ReuseAdaptiveSubquery(context.subqueryCache),
+ PrepareScans,
Review comment:
It would be nice to move `PlanAdaptiveDynamicPruningFilters` and
`PrepareScans` to prep rules in AQE just like I added `PrepareScans` to prep
rules for non-AQE path. It is a bit tricky, though.
`PlanAdaptiveDynamicPruningFilters` references the root node while prep rules
are run immediately upon construction. Let me give it a try.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -96,6 +96,7 @@ case class AdaptiveSparkPlanExec(
@transient private val queryStageOptimizerRules: Seq[Rule[SparkPlan]] = Seq(
PlanAdaptiveDynamicPruningFilters(this),
ReuseAdaptiveSubquery(context.subqueryCache),
+ PrepareScans,
Review comment:
It would be nice to move `PlanAdaptiveDynamicPruningFilters` and
`PrepareScans` to prep rules in AQE just like I added `PrepareScans` to prep
rules for non-AQE path.
It is a bit tricky, though. `PlanAdaptiveDynamicPruningFilters` references
the root node while prep rules are run immediately upon construction. Let me
give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
