Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/5604#discussion_r29542176
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -195,9 +202,28 @@ case class Aggregate(
child: LogicalPlan)
extends UnaryNode {
+ override lazy val resolved: Boolean = {
+ val hasWindowExpressions = aggregateExpressions.exists ( _.collect {
+ case window: WindowExpression => window
+ }.nonEmpty
+ )
+
+ !expressions.exists(!_.resolved) && childrenResolved &&
!hasWindowExpressions
+ }
+
override def output: Seq[Attribute] =
aggregateExpressions.map(_.toAttribute)
}
+case class Window(
+ projectList: Seq[Attribute],
+ windowExpressions: Seq[NamedExpression],
+ windowSpec: WindowSpecDefinition,
--- End diff --
can we not put windowSpec in window's argument since we can get it from
windowExpressions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
