xuanyuanking commented on a change in pull request #32928:
URL: https://github.com/apache/spark/pull/32928#discussion_r654942339
##########
File path: sql/core/pom.xml
##########
@@ -35,6 +35,11 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.rocksdb</groupId>
+ <artifactId>rocksdbjni</artifactId>
+ <version>6.2.2</version>
Review comment:
@dongjoon-hyun Thanks for taking care. Following the comments from Yikun
in
http://apache-spark-developers-list.1001551.n3.nabble.com/DISCUSS-Add-RocksDB-StateStore-tt30645.html,
I planned to upgrade the rocksdb version after all the code shipped. At least
>=6.4.6 for the Arm64 support.
Personally, I think it's good to keep the 6.2.2 since this is well tested in
the production environment and it's safe to use it in the first stage. I
believe the latest RocksDB versions are stable enough, but the state store
implementation has its own design on the snapshot/checkpoint file architecture,
it's good to spend more time on testing whether we can safely upgrade it to the
latest RocksDB version. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
