cloud-fan commented on a change in pull request #32963:
URL: https://github.com/apache/spark/pull/32963#discussion_r655053272
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -597,7 +597,8 @@ class Dataset[T] private[sql](
* @group basic
* @since 1.6.0
*/
- def isLocal: Boolean = logicalPlan.isInstanceOf[LocalRelation]
+ def isLocal: Boolean = logicalPlan.isInstanceOf[LocalRelation] ||
+ logicalPlan.isInstanceOf[CommandResult]
Review comment:
+1, this API has no test as all, we can add one in `DataFrameSuite`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -597,7 +597,8 @@ class Dataset[T] private[sql](
* @group basic
* @since 1.6.0
*/
- def isLocal: Boolean = logicalPlan.isInstanceOf[LocalRelation]
+ def isLocal: Boolean = logicalPlan.isInstanceOf[LocalRelation] ||
+ logicalPlan.isInstanceOf[CommandResult]
Review comment:
+1, this API has no test at all, we can add one in `DataFrameSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
