c21 commented on a change in pull request #32881:
URL: https://github.com/apache/spark/pull/32881#discussion_r655114198
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##########
@@ -96,7 +96,7 @@ object FileFormatWriter extends Logging {
sparkSession: SparkSession,
plan: SparkPlan,
fileFormat: FileFormat,
- committer: FileCommitProtocol,
+ protocols: (FileCommitProtocol, FileNamingProtocol),
Review comment:
From my side, whenever I add the 11th parameter of a scala method,
intellij will mark it as a lint error. Do we have # of parameter rule in Spark?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -1405,9 +1405,9 @@ object QueryExecutionErrors {
s"Multiple streaming queries are concurrently using $path", e)
}
- def addFilesWithAbsolutePathUnsupportedError(commitProtocol: String):
Throwable = {
+ def addFilesWithAbsolutePathUnsupportedError(protocol: String): Throwable = {
Review comment:
@cloud-fan - sorry, this does not need. Was calling it from naming
protocol as well in one iteration. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
