viirya commented on a change in pull request #32747:
URL: https://github.com/apache/spark/pull/32747#discussion_r655135698
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReaderAdmin.scala
##########
@@ -135,12 +136,12 @@ private[kafka010] class KafkaOffsetReaderAdmin(
}.toMap
case SpecificOffsetRangeLimit(partitionOffsets) =>
validateTopicPartitions(partitions, partitionOffsets)
- case SpecificTimestampRangeLimit(partitionTimestamps) =>
- fetchSpecificTimestampBasedOffsets(partitionTimestamps,
- failsOnNoMatchingOffset = isStartingOffsets).partitionToOffsets
- case GlobalTimestampRangeLimit(timestamp) =>
- fetchGlobalTimestampBasedOffsets(timestamp,
- failsOnNoMatchingOffset = isStartingOffsets).partitionToOffsets
+ case SpecificTimestampRangeLimit(partitionTimestamps,
strategyOnNoMatchingStartingOffset) =>
+ fetchSpecificTimestampBasedOffsets(partitionTimestamps,
isStartingOffsets,
+ strategyOnNoMatchingStartingOffset).partitionToOffsets
+ case GlobalTimestampRangeLimit(timestamp,
strategyOnNoMatchingStartingOffset) =>
+ fetchGlobalTimestampBasedOffsets(timestamp, isStartingOffsets,
+ strategyOnNoMatchingStartingOffset).partitionToOffsets
Review comment:
Oh, I see. `fetchPartitionOffsets` is only called for batch query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
