mridulm commented on a change in pull request #32992:
URL: https://github.com/apache/spark/pull/32992#discussion_r655453668
##########
File path:
core/src/test/scala/org/apache/spark/shuffle/ShuffleBlockPusherSuite.scala
##########
@@ -56,8 +56,6 @@ class ShuffleBlockPusherSuite extends SparkFunSuite with
BeforeAndAfterEach {
when(dependency.partitioner).thenReturn(new HashPartitioner(8))
when(dependency.serializer).thenReturn(new JavaSerializer(conf))
when(dependency.getMergerLocs).thenReturn(Seq(BlockManagerId("test-client",
"test-client", 1)))
- conf.set("spark.shuffle.push.based.enabled", "true")
- conf.set("spark.shuffle.service.enabled", "true")
Review comment:
Dont we need to enable push based shuffle ? via
`spark.shuffle.push.enabled` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
