gengliangwang commented on a change in pull request #32995:
URL: https://github.com/apache/spark/pull/32995#discussion_r655542522
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -66,6 +66,10 @@ trait TimestampFormatterHelper extends
TimeZoneAwareExpression {
protected def isParsing: Boolean
+ // Whether the timestamp formatter is for TimestampWithoutTZType.
+ // If yes, the formatter is always `Iso8601TimestampFormatter`.
Review comment:
Well I prefer to put all the logic in `TimestampFormatter.getFormatter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
