karenfeng commented on a change in pull request #32850: URL: https://github.com/apache/spark/pull/32850#discussion_r655600869
########## File path: core/src/main/scala/org/apache/spark/SparkError.scala ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark + +import java.net.URL + +import scala.collection.immutable.SortedMap + +import com.fasterxml.jackson.annotation.JsonIgnore +import com.fasterxml.jackson.core.`type`.TypeReference +import com.fasterxml.jackson.databind.SerializationFeature +import com.fasterxml.jackson.databind.json.JsonMapper +import com.fasterxml.jackson.module.scala.DefaultScalaModule + +import org.apache.spark.util.Utils + +/** + * Information associated with an error class. + * + * @param sqlState SQLSTATE associated with this class. + * @param messageFormatLines C-style message format compatible with printf. + * The error message is constructed by concatenating the lines with + * linebreaks. + */ +case class ErrorInfo(sqlState: Option[String], messageFormatLines: Seq[String]) { Review comment: I agree; SQLSTATE is a SQL concept. Off the top of my head, I'm not sure how to have this only be set in the `sql` component without increasing the complexity of the implementation: - Create a JSON file that maps error classes to SQLSTATE in SQL, which may increase maintenance burden and decrease developer usability - Create a `SqlErrorInfo(sqlState, messageFormatLines)` class that extends `ErrorInfo(messageFormatLines)` in the `sql` component, and parse the JSON file again to get the `sqlState` field What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
