gengliangwang commented on a change in pull request #32998: URL: https://github.com/apache/spark/pull/32998#discussion_r655224583
########## File path: .gitignore ########## @@ -15,8 +15,8 @@ .ensime_cache/ .ensime_lucene .generated-mima* -# The star is required for further !.idea/ to work, see https://git-scm.com/docs/gitignore -.idea/* Review comment: Actually, the star is not required. with the current gitignore of this PR, the change of `.idea/vcs.xml` is not ignored and the links on IDEA works. ########## File path: .gitignore ########## @@ -15,8 +15,8 @@ .ensime_cache/ .ensime_lucene .generated-mima* -# The star is required for further !.idea/ to work, see https://git-scm.com/docs/gitignore -.idea/* Review comment: Well we can always add the new file with `-f` option. Git has hint for this: ``` $ git add .idea/foo The following paths are ignored by one of your .gitignore files: .idea hint: Use -f if you really want to add them. hint: Turn this message off by running hint: "git config advice.addIgnoredFile false" $ git add -f .idea/foo $ git st On branch improveIgnore Changes to be committed: (use "git restore --staged <file>..." to unstage) new file: .idea/foo ``` ########## File path: .gitignore ########## @@ -15,8 +15,8 @@ .ensime_cache/ .ensime_lucene .generated-mima* -# The star is required for further !.idea/ to work, see https://git-scm.com/docs/gitignore -.idea/* +.idea/ +# SPARK-35223: Add IssueNavigationLink to make IDEA support hyperlink on JIRA Ticket and GitHub PR on Git plugin. !.idea/vcs.xml python/.idea Review comment: @HyukjinKwon I added the comment in `.gitignore` instead. The file vcs.xml is already in VCS so any changes will be caught by Git already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
