dongjoon-hyun commented on a change in pull request #33001:
URL: https://github.com/apache/spark/pull/33001#discussion_r655764820
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/HiveCharVarcharTestSuite.scala
##########
@@ -50,6 +52,20 @@ class HiveCharVarcharTestSuite extends CharVarcharTestSuite
with TestHiveSinglet
assert(rest.contains("CHAR(5)"))
}
}
+
+ test("SPARK-35700: Read char/varchar orc table with created and written by
external systems") {
+ val hiveClient = spark.sharedState
+ .externalCatalog.asInstanceOf[ExternalCatalogWithListener]
+ .unwrapped
+ .asInstanceOf[HiveExternalCatalog].client
Review comment:
```suggestion
```
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/HiveCharVarcharTestSuite.scala
##########
@@ -17,7 +17,9 @@
package org.apache.spark.sql
+import org.apache.spark.sql.catalyst.catalog.ExternalCatalogWithListener
import org.apache.spark.sql.execution.command.CharVarcharDDLTestBase
+import org.apache.spark.sql.hive.HiveExternalCatalog
Review comment:
```suggestion
```
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/HiveCharVarcharTestSuite.scala
##########
@@ -17,7 +17,9 @@
package org.apache.spark.sql
+import org.apache.spark.sql.catalyst.catalog.ExternalCatalogWithListener
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
