cloud-fan commented on a change in pull request #33019:
URL: https://github.com/apache/spark/pull/33019#discussion_r656089989



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -186,6 +186,11 @@ trait DateTimeFormatterHelper {
       }
       throw 
QueryExecutionErrors.failToRecognizePatternInDateTimeFormatterError(pattern, e)
   }
+
+  protected def checkInvalidPattern(pattern: String): 
PartialFunction[Throwable, Nothing] = {
+    case e: IllegalArgumentException =>
+      throw QueryExecutionErrors.failToRecognizePatternError(pattern, e)

Review comment:
       what's the difference between this one and 
`QueryExecutionErrors.failToRecognizePatternInDateTimeFormatterError`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to