gengliangwang commented on a change in pull request #33022:
URL: https://github.com/apache/spark/pull/33022#discussion_r656183501
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala
##########
@@ -25,6 +25,11 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.UTF8String
+/**
+ * Test suite base for both [[Cast]] expression with ANSI mode enabled and
[[AnsiCast]] expression.
+ * Note: for new test cases that works for both [[Cast]] and [[AnsiCast]],
please add them
Review comment:
Updated, thanks
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -30,12 +28,12 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils._
import org.apache.spark.sql.catalyst.util.DateTimeUtils._
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
-import org.apache.spark.sql.types.DayTimeIntervalType._
-import org.apache.spark.sql.types.YearMonthIntervalType._
import org.apache.spark.unsafe.types.UTF8String
/**
- * Test suite for data type casting expression [[Cast]].
+ * Test suite for data type casting expression [[Cast]] with ANSI mode
disabled.
+ * Note: for new test cases that works for both [[Cast]] and [[AnsiCast]],
please add them
Review comment:
Updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
