cloud-fan commented on a change in pull request #32850: URL: https://github.com/apache/spark/pull/32850#discussion_r656221248
########## File path: core/src/main/scala/org/apache/spark/SparkError.scala ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark + +import java.net.URL + +import scala.collection.immutable.SortedMap + +import com.fasterxml.jackson.annotation.JsonIgnore +import com.fasterxml.jackson.core.`type`.TypeReference +import com.fasterxml.jackson.databind.SerializationFeature +import com.fasterxml.jackson.databind.json.JsonMapper +import com.fasterxml.jackson.module.scala.DefaultScalaModule + +import org.apache.spark.util.Utils + +/** + * Information associated with an error class. + * + * @param sqlState SQLSTATE associated with this class. + * @param message C-style message format compatible with printf. + * The error message is constructed by concatenating the lines with newlines. + */ +case class ErrorInfo(sqlState: Option[String], message: Seq[String]) { + // For compatibility with multi-line error messages + @JsonIgnore + val messageFormat: String = message.mkString("\n") +} + +/** + * Companion object used by instances of [[SparkError]] to access error class information and + * construct error messages. + */ +object SparkError { + val errorClassesUrl: URL = + Utils.getSparkClassLoader.getResource("error/error-classes.json") + val mapper: JsonMapper = JsonMapper.builder() Review comment: nit: if `mapper` is only an intermediate value, let's not expose it and allow it to be GCed ``` val errorClassToInfoMap: SortedMap[String, ErrorInfo] = { val mapper = ... ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
