Peng-Lei commented on a change in pull request #32931:
URL: https://github.com/apache/spark/pull/32931#discussion_r656227832



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala
##########
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import scala.collection.mutable
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.catalyst.util.escapeSingleQuotedString
+import org.apache.spark.sql.connector.catalog.{CatalogV2Util, Table, 
TableCatalog}
+import org.apache.spark.sql.connector.expressions.{BucketTransform, 
DaysTransform, HoursTransform, IdentityTransform, MonthsTransform, 
YearsTransform}
+import org.apache.spark.sql.errors.{QueryCompilationErrors, 
QueryExecutionErrors}
+import org.apache.spark.sql.execution.LeafExecNode
+import org.apache.spark.unsafe.types.UTF8String
+
+/**
+ * Physical plan node for show create table.
+ */
+case class ShowCreateTableExec(
+    output: Seq[Attribute],
+    table: Table) extends V2CommandExec with LeafExecNode {
+  override protected def run(): Seq[InternalRow] = {
+    val builder = StringBuilder.newBuilder
+    // it is used to generate Spark DDL for given table. include Hive Serde 
table
+    showCreateTable(table, builder)
+    Seq(InternalRow(UTF8String.fromString(builder.toString)))
+  }
+
+  private def showCreateTable(table: Table, builder: StringBuilder): Unit = {
+    builder ++= s"CREATE TABLE ${table.name()} "
+    val isHive = isHiveTable(table)
+    if (isHive) {
+      // need convert the SerdeInfo from table.properties
+      throw 
QueryCompilationErrors.showCreateTableNotSupportedForV2TablesError()
+    }
+    showTableDataColumns(table, builder)
+    showTableUsing(table, builder)
+    showTableOptions(table, builder)
+    showTableNonDataColumns(table, builder)
+    showTableComment(table, builder)
+    showTableLocation(table, builder)
+    showTableProperties(table, builder)
+  }
+
+  private def showTableDataColumns(table: Table, builder: StringBuilder): Unit 
= {
+    val columns = table.schema().fields.map(_.toDDL)
+    builder ++= concatByMultiLines(columns)
+  }
+
+  private def showTableUsing(table: Table, builder: StringBuilder): Unit = {
+    if (table.properties.containsKey(TableCatalog.PROP_PROVIDER)) {
+      builder ++=
+        s"USING 
${escapeSingleQuotedString(table.properties().get(TableCatalog.PROP_PROVIDER))}\n"
+    }
+  }
+
+  private def showTableOptions(table: Table, builder: StringBuilder): Unit = {
+    import scala.collection.JavaConverters._
+    val dataSourceOptions = table.properties.asScala
+      .filterKeys(_.startsWith(TableCatalog.OPTION_PREFIX))
+    if (dataSourceOptions.nonEmpty) {
+      val props = dataSourceOptions.map { case (key, value) =>
+        s"'${escapeSingleQuotedString(key)}' = 
'${escapeSingleQuotedString(value)}'"
+      }
+
+      builder ++= "OPTIONS "
+      builder ++= concatByMultiLines(props)
+    }
+  }
+
+  private def showTableNonDataColumns(table: Table, builder: StringBuilder): 
Unit = {
+    if (!table.partitioning.isEmpty) {
+      val identityCols = new mutable.ArrayBuffer[String]

Review comment:
       `transforms` is a better way to express meaning.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to