xkrogen commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r656369998
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -264,6 +265,8 @@ private void checkAuth(TransportClient client, String
appId) {
private final Timer registerExecutorRequestLatencyMillis = new Timer();
// Time latency for processing finalize shuffle merge request latency in ms
private final Timer finalizeShuffleMergeLatencyMillis = new Timer();
+ // Block transfer rate in blocks per second
Review comment:
Thanks for that context @mridulm! To clarify, are you suggesting we
ditch the new proposal and only maintain the old version, which would treat a
batch fetch as a single block transfer?
From the comments on #32140, it seems like @otterc was indicating that
there's a future plan to add metrics on the push-based shuffle side that also
break out the merged chunks in terms of number of underlying blocks. Should we
do the same here (which is basically my new proposal)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
