dongjoon-hyun commented on a change in pull request #33030:
URL: https://github.com/apache/spark/pull/33030#discussion_r656471352
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -142,7 +142,7 @@ private[sql] object OrcFilters extends OrcFiltersBase {
case BooleanType => PredicateLeaf.Type.BOOLEAN
case ByteType | ShortType | IntegerType | LongType =>
PredicateLeaf.Type.LONG
case FloatType | DoubleType => PredicateLeaf.Type.FLOAT
- case StringType | _: CharType | _: VarcharType => PredicateLeaf.Type.STRING
+ case StringType => PredicateLeaf.Type.STRING
Review comment:
Thank you so much for your swift fix, @cloud-fan . Do you think we can
have a test coverage to prevent us from making this mistake again please?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -142,7 +142,7 @@ private[sql] object OrcFilters extends OrcFiltersBase {
case BooleanType => PredicateLeaf.Type.BOOLEAN
case ByteType | ShortType | IntegerType | LongType =>
PredicateLeaf.Type.LONG
case FloatType | DoubleType => PredicateLeaf.Type.FLOAT
- case StringType | _: CharType | _: VarcharType => PredicateLeaf.Type.STRING
+ case StringType => PredicateLeaf.Type.STRING
Review comment:
Thank you so much for your swift fix, @cloud-fan . Do you think we can
have a test coverage to prevent us from making this mistake again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
