peter-toth commented on a change in pull request #33021:
URL: https://github.com/apache/spark/pull/33021#discussion_r656523986



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala
##########
@@ -479,9 +479,9 @@ abstract class BroadcastJoinSuiteBase extends QueryTest 
with SQLTestUtils
   test("broadcast join where streamed side's output partitioning is 
PartitioningCollection") {
     withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "500") {
       val t1 = (0 until 100).map(i => (i % 5, i % 13)).toDF("i1", "j1")
-      val t2 = (0 until 100).map(i => (i % 5, i % 13)).toDF("i2", "j2")

Review comment:
       These slight changes are needed to avoid `ReuseExchange` nodes in the 
test plans as this PR changes the `ReuseExchangeAndSubquery` rule to identify 
reuses based on canonicalized plans only (the schema of the exchanges are no 
longer need to match).
   Without these changes the canonicalized plans of `LocalTableScanExec` in t1, 
t2 and t4 are the same as they have the same content.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to