gengliangwang commented on a change in pull request #33022:
URL: https://github.com/apache/spark/pull/33022#discussion_r656732920
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala
##########
@@ -25,6 +25,14 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.UTF8String
+/**
+ * Test suite base for
+ * 1. [[Cast]] with ANSI mode enabled
+ * 2. [[AnsiCast]]
+ * 3. [[TryCast]]
Review comment:
Yes `TryCast` is identical to CAST with configuration
`spark.sql.ansi.enabled` as true. For the test cases in AnsiCastSuiteBase are
suitable for `TryCastSuite` except that all the exceptions should not happen in
the test suite. There is a hack for overriding `checkExceptionInExpression` in
`TryCastSuite` to ensure that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
