cloud-fan commented on a change in pull request #33027:
URL: https://github.com/apache/spark/pull/33027#discussion_r656753977
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1942,16 +1942,18 @@ abstract class CastBase extends UnaryExpression with
TimeZoneAwareExpression wit
""",
since = "1.0.0",
group = "conversion_funcs")
-case class Cast(child: Expression, dataType: DataType, timeZoneId:
Option[String] = None)
+case class Cast(
+ child: Expression,
+ dataType: DataType,
+ timeZoneId: Option[String] = None,
+ override val ansiEnabled: Boolean = SQLConf.get.ansiEnabled)
extends CastBase {
Review comment:
I checked `Add`, I think we should also add a new `def this` to allow
omitting the `ansiEnabled` parameter, to get a bit more compatibility, such as
`new Cast(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
