Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5834#discussion_r29546349
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -251,6 +251,11 @@ case class InsertIntoHiveTable(
}
}
+ //remove temporary directories
+ val fs = outputPath.getFileSystem(jobConf)
+ if ( outputPath.getParent.isRoot == false )
--- End diff --
I think the code uses `!` instead of `== false`. There shouldn't be space
around the arg, and add the braces here too.
Why delete the root though? `outputPath` ought to be what you delete
recursively.
I think you're correct given the comments though I don't know enough about
this API to be sure.
Can you add `[SQL]` to the title please? normal format is `[SPARK-7300]
[SQL] ...`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
