c21 commented on pull request #33012: URL: https://github.com/apache/spark/pull/33012#issuecomment-867074220
> taskContext: TaskAttemptContext, dir: Option[String], prefix: String,ext: String @gengliangwang - I agree with @cloud-fan. The `FileNameSpec` class is introduced mainly for future-proof. Whenever in the future we need pass more parameters to customize file name (e.g. require randomness/UUID, etc), we can just add more field into `FileNameSpec`. We don't need to break the API again. Future-proof is the main purpose here other than encapsulation. How about keeping `FileNameSpec` as it is? > Ya, I know this is internal, but are we able to remove that API in the future at Apache Spark 3.3.0? Why don't we remove deprecation warnings from this PR? After we file a JIRA and discuss in email thread, we can add them later. @dongjoon-hyun - based on people's opinions here, I removed the `deprecated` annotations of existing APIs. I agree with your plan. I will have a discussion in mailing list for Spark 3.3 later, and we can add `deprecated` later or just remove the existing APIs. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
