Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5853#discussion_r29546728
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala
 ---
    @@ -108,9 +110,13 @@ class WriteAheadLogBackedBlockRDD[T: ClassTag](
               // writing log data. However, the directory is not needed if 
data needs to be read, hence
               // a dummy path is provided to satisfy the method parameter 
requirements.
               // FileBasedWriteAheadLog will not create any file or directory 
at that path.
    -          val dummyDirectory = FileUtils.getTempDirectoryPath()
    +          // FileBasedWriteAheadLog will not create any file or directory 
at that path. Also,
    +          // this dummy directory should not already exist otherwise the 
WAL will try to recover
    +          // past events from the directory and throw errors.
    +          val nonExistentDirectory = new File(
    +            FileUtils.getTempDirectory(), 
UUID.randomUUID().toString).getAbsolutePath
    --- End diff --
    
    Yeah, I thought the same. But then why do an additional file creation and 
deletion, especially when this is going to run potentially 10s of times every 
second. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to