cloud-fan commented on a change in pull request #30319:
URL: https://github.com/apache/spark/pull/30319#discussion_r657620789
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala
##########
@@ -70,6 +70,11 @@ object SparkHadoopWriter extends Logging {
// Assert the output format/key/value class is set in JobConf.
config.assertConf(jobContext, rdd.conf)
+ // propagate the description UUID into the jobs, so that committers
+ // get an ID guaranteed to be unique.
+ jobContext.getConfiguration.set("spark.sql.sources.writeJobUUID",
Review comment:
I'm wondering why is this needed. Can't commit protocol just get a
unique job ID from the constructor parameters?
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala#L32-L34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
