MaxGekk commented on a change in pull request #33057:
URL: https://github.com/apache/spark/pull/33057#discussion_r657872516
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2521,23 +2521,33 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with SQLConfHelper with Logg
}
override def visitYearMonthIntervalDataType(ctx:
YearMonthIntervalDataTypeContext): DataType = {
- val start =
YearMonthIntervalType.stringToField(ctx.from.getText.toLowerCase(Locale.ROOT))
- val end = if (ctx.to != null) {
-
YearMonthIntervalType.stringToField(ctx.to.getText.toLowerCase(Locale.ROOT))
+ val startStr = ctx.from.getText.toLowerCase(Locale.ROOT)
+ val start = YearMonthIntervalType.stringToField(startStr)
+ if (ctx.to != null) {
+ val endStr = ctx.to.getText.toLowerCase(Locale.ROOT)
+ val end = YearMonthIntervalType.stringToField(endStr)
+ if (start == end) {
+ throw QueryParsingErrors.fromToIntervalUnsupportedError(startStr,
endStr, ctx)
+ }
+ YearMonthIntervalType(start, end)
} else {
- start
+ YearMonthIntervalType(start)
}
- YearMonthIntervalType(start, end)
}
override def visitDayTimeIntervalDataType(ctx:
DayTimeIntervalDataTypeContext): DataType = {
- val start =
DayTimeIntervalType.stringToField(ctx.from.getText.toLowerCase(Locale.ROOT))
- val end = if (ctx.to != null ) {
-
DayTimeIntervalType.stringToField(ctx.to.getText.toLowerCase(Locale.ROOT))
+ val startStr = ctx.from.getText.toLowerCase(Locale.ROOT)
+ val start = DayTimeIntervalType.stringToField(startStr)
+ if (ctx.to != null ) {
+ val endStr = ctx.to.getText.toLowerCase(Locale.ROOT)
+ val end = DayTimeIntervalType.stringToField(endStr)
+ if (start == end) {
Review comment:
Should we prohibit anything in which `start >= end` like: `INTERVAL
MINUTE TO DAY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
