xuanyuanking commented on a change in pull request #32767:
URL: https://github.com/apache/spark/pull/32767#discussion_r658040266
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala
##########
@@ -53,10 +62,24 @@ class RocksDBSuite extends SparkFunSuite {
"archive/00002.log" -> 2000
)
saveCheckpointFiles(fileManager, cpFiles1, version = 1, numKeys = 101)
+ assert(fileManager.getLatestVersion() === 1)
assert(numRemoteSSTFiles == 2) // 2 sst files copied
assert(numRemoteLogFiles == 2) // 2 log files copied
- // Save SAME version again with different checkpoint files and verify
+ // Load back the checkpoint files into another local dir with existing
files and verify
+ generateFiles(verificationDir, Seq(
+ "sst-file1.sst" -> 11, // files with same exist but different sizes,
should get overwritten
Review comment:
Ah thanks! Fix done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
