Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4946#discussion_r29551526
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
 ---
    @@ -296,7 +296,7 @@ abstract class HiveComparisonTest
     
                 val hiveQueries = queryList.map(new 
TestHive.HiveQLQueryExecution(_))
                 // Make sure we can at least parse everything before 
attempting hive execution.
    -            hiveQueries.foreach(_.logical)
    +            hiveQueries.foreach(_.analyzed)
    --- End diff --
    
    This change breaks golden answer generation.  You can't analyze queries 
unless you are also executing DDL from previous queries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to