mridulm commented on a change in pull request #33063:
URL: https://github.com/apache/spark/pull/33063#discussion_r658519592
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -397,21 +400,21 @@ final class ShuffleBlockFetcherIterator(
}
private def createFetchRequest(
- blocks: Seq[FetchBlockInfo],
+ blocks: ArrayBuffer[FetchBlockInfo],
address: BlockManagerId): FetchRequest = {
logDebug(s"Creating fetch request of ${blocks.map(_.size).sum} at $address
"
+ s"with ${blocks.size} blocks")
- FetchRequest(address, blocks)
+ FetchRequest(address, blocks.toSeq)
}
private def createFetchRequests(
Review comment:
For this PR, do we really need to modify this method ? (other than a
`retBlocks = blocks.toSeq` part).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
