holdenk commented on a change in pull request #32921:
URL: https://github.com/apache/spark/pull/32921#discussion_r658920527
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -631,6 +631,19 @@ object DataSourceStrategy
}
}
+ protected[sql] def translateRuntimeFilter(expr: Expression): Option[Filter]
= expr match {
Review comment:
Super minor suggestion, we could maybe add some scaladoc here on the
expected behaviour, I note that in one case it rases an exception and in the
other case it returns None to indicate it isn't able to handle the filter and I
think clarifying that could be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
