itholic commented on a change in pull request #33054:
URL: https://github.com/apache/spark/pull/33054#discussion_r659426716



##########
File path: python/pyspark/pandas/plot/core.py
##########
@@ -20,7 +20,7 @@
 import pandas as pd
 import numpy as np
 from pyspark.ml.feature import Bucketizer
-from pyspark.mllib.stat import KernelDensity
+from pyspark.mllib.stat.KernelDensity import KernelDensity

Review comment:
       Otherwise it raises `mypy checks failed:
   python/pyspark/pandas/plot/core.py:23: error: Name 'KernelDensity' already 
defined (by an import)` for some reason.
   
   Anyway I think it's really weird because seems like my changes don't affect 
to the `KernelDensity` side at all, but the `mypy` check started to fail.
   
   And the more weird fact is that the `KernelDensity` is only imported here 
across whole project (pandas-on-Spark), but it suddenly says already defined.
   
   Let me just ignore this case for now, and investigate more in mypy side. I 
couldn't find the related bug so far.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to