HyukjinKwon commented on a change in pull request #33100:
URL: https://github.com/apache/spark/pull/33100#discussion_r659455547
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1218,6 +1219,7 @@ object EliminateSorts extends Rule[LogicalPlan] {
_.containsPattern(SORT))(applyLocally)
private val applyLocally: PartialFunction[LogicalPlan, LogicalPlan] = {
+ case Sort(_, _, child) if child.maxRows.exists(_ <= 1L) => child
Review comment:
The change here looks good. I wonder if we should better create a
separate file to group similar stuff though .... e.g.) we can remove
deduplicate too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
